search

jump-dev / ECOS.jl

A Julia interface to the ECOS conic optimization solver
https://github.com/embotech/ecos
Other
41 stars 17 forks source link

Use a constant ECOS_VERSION instead of recomputing version #83

Closed ararslan closed 4 years ago

ararslan commented 5 years ago

This moves the ECOS version from being recomputed via a ccall into the library on demand to a compile-time constant. This is may or may not help with the allocations noted in https://github.com/JuliaOpt/Convex.jl/issues/254#issuecomment-447860140, but at least it avoids having to recompute the version number.

It also adds a missing call to check_deps in __init__, which is recommended by all applications using BinaryProvider, and removes the note about Homebrew from the error message, as that is no longer relevant.

codecov-io commented 5 years ago

Codecov Report

Merging #83 into master will increase coverage by 0.18%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   90.31%   90.49%   +0.18%     
==========================================
  Files           4        4              
  Lines         444      442       -2     
==========================================
- Hits          401      400       -1     
+ Misses         43       42       -1
Impacted Files Coverage Δ
src/types.jl 100% <ø> (ø) :arrow_up:
src/ECOS.jl 96.15% <75%> (+3.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5df368...af446da. Read the comment docs.

omus commented 4 years ago

Note that this change make would also cause issues with generating system images: https://github.com/jump-dev/ECOS.jl/issues/106

omus commented 4 years ago

It should be safe to close this PR