search

jump-dev / ECOS.jl

A Julia interface to the ECOS conic optimization solver
https://github.com/embotech/ecos
Other
41 stars 17 forks source link

♻️ Simplify thanks to VectorizeBridge #88

Closed blegat closed 5 years ago

blegat commented 5 years ago

Note the 38 lines drop in src/MOI_wrapper.jl :tada: Closes https://github.com/JuliaOpt/ECOS.jl/issues/85

codecov-io commented 5 years ago

Codecov Report

Merging #88 into master will decrease coverage by 0.57%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   89.91%   89.33%   -0.58%     
==========================================
  Files           4        4              
  Lines         446      422      -24     
==========================================
- Hits          401      377      -24     
  Misses         45       45
Impacted Files Coverage Δ
src/MOI_wrapper.jl 82.77% <100%> (-2.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8d440c...1900e27. Read the comment docs.

chriscoey commented 5 years ago

Much nicer