search

jump-dev / ECOS.jl

A Julia interface to the ECOS conic optimization solver
https://github.com/embotech/ecos
Other
41 stars 17 forks source link

Add Homebrew support #9

Closed staticfloat closed 10 years ago

staticfloat commented 10 years ago

Also updates deps/build.jl to install the version with our patches merged in. Once upstream releases 1.0.5, we can update to using that instead, but since all tests pass and this simplifies our burden of carrying around patches, this seemed like a good plan to me.

jfsantos commented 10 years ago

I tried using this but when running Pkg.build("ECOS"), Homebrew was updated to the latest version but in the end the tarball was downloaded and built from scratch, instead of installing from the bottle. Did I do anything wrong?

staticfloat commented 10 years ago

Did you run Pkg.update() first?

jfsantos commented 10 years ago

Forget it, I did something wrong.

staticfloat commented 10 years ago

Oh, great. :P Is it working now?

jfsantos commented 10 years ago

I just redid all the steps and it is still building from scratch. Now I did everything right (or so it seems), so I may have a problem with my Homebrew setup. Any ideas?

staticfloat commented 10 years ago

Show me the output of these steps:

julia> using Homebrew

julia> Homebrew.info("ecos")
ecos: 1.0.4+1 (bottled)
jfsantos commented 10 years ago

It shows exactly the same output. However, calling Pkg.build("ECOS") does this instead:

julia> Pkg.build("ECOS")
INFO: Building Homebrew
HEAD is now at ad22f15 libetonyek: update 0.1.1 bottle.
HEAD is now at 997d9e3 Ecos bottled!
INFO: Building ECOS
INFO: Attempting to Create directory /Users/jfsantos/.julia/v0.3/ECOS/deps/downloads
INFO: Downloading file https://github.com/ifa-ethz/ecos/archive/d206a556a83396756f3200964de162b4a7523c62.tar.gz

and then proceeds to build ECOS from scratch.

staticfloat commented 10 years ago

My bad. I accidentally pushed a version that I used to test that the source version still works; the Homebrew stuff is all commented out. XD Fixed now.

jfsantos commented 10 years ago

Haha, I should have checked the source files. It works now, so I think we can merge this. @IainNZ, any other comments?

IainNZ commented 10 years ago

I'll try it on my machine in an hour or so just to triple check but LGTM

tkelman commented 10 years ago

why you gotta give me merge conflicts?