WIP. Refactor GRBupdatemodel calls

jump-dev / Gurobi.jl

A Julia interface to the Gurobi Optimizer

http://www.gurobi.com/

MIT License

221 stars 80 forks source link

WIP. Refactor GRBupdatemodel calls #550

Closed torressa closed 6 months ago

torressa commented 6 months ago

WIP. The idea is to only call GRBupdatemodel before GRBget*. Some tests are failing still:

[ ] test_Buffered_deletion_test, test_modify_after_delete* (indexing should also be updated with delete? This is not expected from our other APIs)

Fixes https://github.com/jump-dev/Gurobi.jl/issues/516

odow commented 6 months ago

CI will fail because you don't have access to the CI secrets. I'll send you an invite, and then you can push to the jump-dev remote and get access to CI.

odow commented 6 months ago

I remember when writing parts of this that I got very confused as to when a call to GRBupdate was necessary. So I defaulted to requiring an update anytime the model was modified, and ensuring update had been called before querying any data about the model.

torressa commented 6 months ago

Thanks Oscar! I've managed to get the CI to run. I'll continue in the other PR. Sorry for the mess.