search

jump-dev / HiGHS.jl

A Julia interface to the HiGHS solver
https://highs.dev
MIT License
103 stars 14 forks source link

modify #117

Closed matbesancon closed 2 years ago

matbesancon commented 2 years ago

It's not clear whether the MOI tests will automatically cover scalar modifications? There is no support trait

codecov[bot] commented 2 years ago

Codecov Report

Merging #117 (ae88710) into master (cb03949) will decrease coverage by 0.50%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   83.24%   82.74%   -0.51%     
==========================================
  Files           3        3              
  Lines        1313     1321       +8     
==========================================
  Hits         1093     1093              
- Misses        220      228       +8
Impacted Files Coverage Δ
src/MOI_wrapper.jl 92.43% <0.00%> (-0.69%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb03949...ae88710. Read the comment docs.

matbesancon commented 2 years ago

good point I had forgotten this. Was there a reason for this difference in API?

odow commented 2 years ago

ConstraintSet is an abstract constraint attribute that can be get, so it should also be set.

Modifying coefficients inside a function is something different.