Closed kpamnany closed 1 year ago
Does Highs_run call back into Julia?
Not currently, but it may do in future.
Is this the only call that can run for minutes?
There are other calls, but we don't use them at the moment.
Let me take a deeper look at this PR. I would prefer that we put the region around
https://github.com/jump-dev/HiGHS.jl/blob/7316ac9140d97f3dda4bd46c48455582f20cc790/src/MOI_wrapper.jl#L1815
and left the automatically built libhighs.jl
alone
Moved the region to MOI_wrapper.jl
.
Did you find this instance because of some benchmark? I guess this might actually be a problem for most of the JuMP solvers
All modified lines are covered by tests :white_check_mark:
Comparison is base (
7316ac9
) 83.31% compared to head (3dadf96
) 83.34%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I work at RelationalAI; we're using Julia to build our product. The freeze I mention happened to us. 😢
This is likely a problem with the other solvers as well, as well as any package that wraps an external library (i.e. uses ccall
) that implements possibly long-running logic.
Can I request a new patch release with this fix?
I work at RelationalAI
Ah :smile:
What other solvers do you need me to look at?
Can I request a new patch release with this fix?
Yip
What other solvers do you need me to look at?
Let me get back on that one.
Thanks very much!
Here are other jump-dev
solvers that are relevant to us, but don't need an immediate fix:
Cc: @bachdavi
I think these are all safe:
run
Prevent a long-running
Highs_run
call from blocking GC (and freezing other Julia threads). Ref: https://github.com/JuliaLang/julia/issues/51574Questions:
Highs_run
call back into Julia?