jump-dev / JuMP.jl

Modeling language for Mathematical Optimization (linear, mixed-integer, conic, semidefinite, nonlinear)
http://jump.dev/JuMP.jl/
Other
2.24k stars 396 forks source link

[docs] add DisjunctiveProgramming #3598

Closed odow closed 11 months ago

odow commented 11 months ago

Probably going to need a few fixes

cc @pulsipher cc @hdavid16

https://jump.dev/JuMP.jl/previews/PR3598/packages/DisjunctiveProgramming/

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cecc5ba) 98.39% compared to head (08c0f9e) 97.69%. Report is 20 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3598 +/- ## ========================================== - Coverage 98.39% 97.69% -0.71% ========================================== Files 38 43 +5 Lines 5687 5638 -49 ========================================== - Hits 5596 5508 -88 - Misses 91 130 +39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pulsipher commented 11 months ago

Thanks @odow, I suspected this wouldn't quite work. I think the best way forward would be for me to make a JuMP specific readme like I did for InfiniteOpt. I should have time to do that this week.

joaquimg commented 11 months ago

Another option would be to cleanup the readme since most of it is replicated in the docs.

pulsipher commented 11 months ago

Another option would be to cleanup the readme since most of it is replicated in the docs.

This along with improving the docs is on my TODO list, I just need to find the time :)

pulsipher commented 11 months ago

I think I fixed the vale errors

pulsipher commented 11 months ago

Hold off on merging, I found a few typos I should correct first...

odow commented 11 months ago

Typos that vale didn't catch? Interesting

odow commented 11 months ago

Merging because we can always update later. I don't see the typos @pulsipher is talking about.