search

jump-dev / JuMP.jl

Modeling language for Mathematical Optimization (linear, mixed-integer, conic, semidefinite, nonlinear)
http://jump.dev/JuMP.jl/
Other
2.24k stars 396 forks source link

Rename _error to error_fn #3600

Closed odow closed 11 months ago

odow commented 11 months ago

I have never liked _error as the name of a positional argument, especially when it appears in docstrings.

Part of #3513

codecov[bot] commented 11 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (59cc031) 97.84% compared to head (839981c) 98.29%. Report is 1 commits behind head on master.

Files Patch % Lines
src/variables.jl 54.54% 5 Missing :warning:
src/macros.jl 96.66% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3600 +/- ## ========================================== + Coverage 97.84% 98.29% +0.44% ========================================== Files 38 38 Lines 5669 5686 +17 ========================================== + Hits 5547 5589 +42 + Misses 122 97 -25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.