Closed odow closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a21e616
) 98.33% compared to head (ae03657
) 98.33%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
So this is a tricky decision. We didn't use it in any tests, and it was never used by any extension that we test.
I wonder how common it is in user-land.
An alternative is to fix the iteration ordering with an OrderedDict
.
Closing in favor of #3681
Closes https://github.com/jump-dev/JuMP.jl/issues/3678
This PR is the nuclear option of throwing an error. Technically, this is breaking change, but it blocks a high risk of incorrect usage.
We should look at the tests and
extension-tests.yml
before deciding to merge this: https://github.com/jump-dev/JuMP.jl/actions/runs/7924586714We could make this less breaking by adding methods like:
but even then, things like the constraint dual might be in the "wrong" order.