search

jump-dev / JuMP.jl

Modeling language for Mathematical Optimization (linear, mixed-integer, conic, semidefinite, nonlinear)
http://jump.dev/JuMP.jl/
Other
2.22k stars 393 forks source link

[docs] add deprecation notes to the legacy nonlinear interface docstrings #3711

Closed odow closed 6 months ago

odow commented 6 months ago

I think this has been in enough use now that we can recommend it more strongly.

Preview: https://jump.dev/JuMP.jl/previews/PR3711/api/JuMP/#@NLconstraint

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.37%. Comparing base (a16b383) to head (e436314). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3711 +/- ## ======================================= Coverage 98.37% 98.37% ======================================= Files 43 43 Lines 5736 5737 +1 ======================================= + Hits 5643 5644 +1 Misses 93 93 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

odow commented 6 months ago

I wonder if we should also remove the warning:

image

We've had lots of people use this now, and I've only heard good things.