jump-dev / JuMP.jl

Modeling language for Mathematical Optimization (linear, mixed-integer, conic, semidefinite, nonlinear)
http://jump.dev/JuMP.jl/
Other
2.17k stars 390 forks source link

[docs] add bounds to big-M examples #3720

Closed odow closed 3 months ago

odow commented 3 months ago

x-ref https://github.com/jump-dev/JuMP.jl/pull/3703#issuecomment-2029566988

cc @remi-garcia

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.42%. Comparing base (177d213) to head (f54df52).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3720 +/- ## ======================================= Coverage 98.42% 98.42% ======================================= Files 43 43 Lines 5828 5828 ======================================= Hits 5736 5736 Misses 92 92 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

remi-garcia commented 3 months ago

Thanks for the quick commit.

However, this is not consistent anymore with "If the solver doesn't support indicator constraints and the variables do not have a finite domain, you an use the big-M trick."

I believe that something like "If the solver doesn't support indicator constraints, you can use the big-M trick (which requires variables to have a finite domain)." would be better suited.