search

jump-dev / JuMP.jl

Modeling language for Mathematical Optimization (linear, mixed-integer, conic, semidefinite, nonlinear)
http://jump.dev/JuMP.jl/
Other
2.17k stars 390 forks source link

Improve matrix inequality support #3778

Open odow opened 5 days ago

odow commented 5 days ago

Follow-up to #3766.

In our discussion of https://github.com/jump-dev/JuMP.jl/pull/3766, we never really talked about the fact that == is not ambiguous.

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.39%. Comparing base (4db5a0c) to head (77af7fa).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3778 +/- ## ======================================= Coverage 98.39% 98.39% ======================================= Files 44 44 Lines 5905 5932 +27 ======================================= + Hits 5810 5837 +27 Misses 95 95 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blegat commented 1 hour ago

Can we just replace Nonnegatives here: https://github.com/jump-dev/JuMP.jl/blob/301d46e81cb66c74c6e22cd89fb89ced740f157b/src/macros/%40constraint.jl#L583 What are the other cases that you'd like to intercept ?