search

jump-dev / JuMPTutorials.jl

Tutorials on using JuMP for mathematical optimization in Julia
MIT License
142 stars 38 forks source link

Added N-Queens tutorial #70

Closed mthelm85 closed 4 years ago

mthelm85 commented 4 years ago

This pull request adds a new tutorial for the N-Queens feasibility problem. It includes two images, a Jupyter notebook, and a .jl file that follows the format of those in script/modelling.

frapac commented 4 years ago

Thanks for contributing! It overall looks good. I would maybe add a test in test/modelling to ensure that the tutorial is working fine with the latest version of JuMP.

mthelm85 commented 4 years ago

I would maybe add a test in test/modelling to ensure that the tutorial is working fine with the latest version of JuMP.

Sounds good! Should I add it to test/runtests.jl as well?

EDIT: I went ahead and added a test in test/runtests.jl in addition to adding a file in test/modelling.

frapac commented 4 years ago

Looks good to me!

mthelm85 commented 4 years ago

Great! Do you need me to do anything else or is this ready to be merged?

matbesancon commented 4 years ago

Thanks again that's a cool demo to have here

amontoison commented 4 years ago

@matbesancon @mthelm85 We should add a link to this tutorial in the README.md, no?

matbesancon commented 4 years ago

Yes this would be good to have in another PR