search

jump-dev / KNITRO.jl

A Julia interface to the Artelys Knitro solver
https://www.artelys.com/knitro
Other
78 stars 23 forks source link

Fix model pointer passed to callbacks #277

Closed odow closed 10 months ago

odow commented 10 months ago

This was changed in https://github.com/jump-dev/KNITRO.jl/pull/143. But the change from ptr_model to model seems unintentional.

Based on the docstrings, it seems like it should be the pointer. It might be different to the one in model.

cc @frapac

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a72f2a9) 84.53% compared to head (1281372) 84.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #277 +/- ## ======================================= Coverage 84.53% 84.53% ======================================= Files 3 3 Lines 996 996 ======================================= Hits 842 842 Misses 154 154 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

odow commented 10 months ago

Yeah it seems like this is even a bug fix, because you'd be querying information from the base model, not from the current node that is being processed.