Minimal Updates for JuMP v0.20

jump-dev / MINLPTests.jl

Unit and Integration Tests for JuMP NLP and MINLP solvers

MIT License

12 stars 6 forks source link

Minimal Updates for JuMP v0.20 #18

Closed ccoffrin closed 5 years ago

ccoffrin commented 5 years ago

@odow, @rschwarz, proposed minimal updates to get this package working with JuMP v0.20 so MINLP solvers can be updated accordingly.

@rschwarz, addresses the Ipopt fix you mentioned.

rschwarz commented 5 years ago

Looks good to me :+1:

I wonder whether the tests fail when somebody uses an older version of Ipopt or Ipopt.jl, but that shouldn't matter for CI-reasons.

ccoffrin commented 5 years ago

@odow, any objections to merging and tagging this?

I am wondering if we need to add some more tests to exercise these changes before tagging? https://github.com/JuliaOpt/MathOptInterface.jl/issues/736

odow commented 5 years ago

No objections. The changes to MOI should be hit by the tests in MOI.Test. MINLPTests should really just catch problems with the NLP stuff, which didn't change.

ccoffrin commented 5 years ago

Sounds good!