search

jump-dev / MatrixOptInterface.jl

An interface to pass matrix form problems
MIT License
11 stars 4 forks source link

remove ordering of CONES #10

Closed akshay326 closed 3 years ago

akshay326 commented 3 years ago

still some scaling left :D

codecov[bot] commented 3 years ago

Codecov Report

Merging #10 into master will decrease coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   83.09%   82.97%   -0.13%     
==========================================
  Files           5        5              
  Lines         278      276       -2     
==========================================
- Hits          231      229       -2     
  Misses         47       47
Impacted Files Coverage Δ
src/conic_form.jl 78.94% <100.00%> (-0.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eda206c...ebe61a2. Read the comment docs.

matbesancon commented 3 years ago

should this be merged?

matbesancon commented 3 years ago

it seems to be blocking other PRs in DiffOpt

akshay326 commented 3 years ago

we can go w/o this too, but if the matrices follow constraints in the natural order they are added to an optimizer, then we can very easily differentiate a specific constraint / parameter

akshay326 commented 3 years ago

is there something missing in this PR? Since its not merged, I've to explain people how to make https://github.com/jump-dev/DiffOpt.jl/pull/43 work 😅