jump-dev / MatrixOptInterface.jl

An interface to pass matrix form problems
MIT License
11 stars 4 forks source link

github actions #11

Closed matbesancon closed 3 years ago

matbesancon commented 3 years ago

adding github action for CI and code coverage

matbesancon commented 3 years ago

ping @joaquimg

matbesancon commented 3 years ago

I think CI is fairly fast on GH-actions. Worst thing we can remove them later

matbesancon commented 3 years ago

Since MOI has binary dependencies, then all depending packages also have some, or do you mean direct dependencies?

On Mon, Dec 7, 2020, 19:42 Oscar Dowson notifications@github.com wrote:

@odow commented on this pull request.

In .github/workflows/ci.yml https://github.com/jump-dev/MatrixOptInterface.jl/pull/11#discussion_r537739944 :

  • arch: x64
    • version: '1'
  • os: ubuntu-latest
  • arch: x64
    • version: '1.0'
  • os: ubuntu-latest
  • arch: x64
    • version: '1.0'
  • os: ubuntu-latest
  • arch: x86
    • version: '1'
  • os: windows-latest
  • arch: x64
    • version: '1'
  • os: macOS-latest
  • arch: x64

The rule-of-thumb I went with was:

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jump-dev/MatrixOptInterface.jl/pull/11#pullrequestreview-546431027, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2FDMXNSX6HIWG2VJ2UOFLSTUO2RANCNFSM4UQM3X4A .

odow commented 3 years ago

Usually just direct. You can assume the down-stream dependencies are well-tested, so you just want to test the first-order integration with binaries (e.g., solvers).

matbesancon commented 3 years ago

ping @joaquimg for merging this one :)

joaquimg commented 3 years ago

Nice!