jump-dev / MatrixOptInterface.jl

An interface to pass matrix form problems
MIT License
11 stars 4 forks source link

Implement MOI interface for LP forms #2

Closed blegat closed 4 years ago

blegat commented 4 years ago

This PR reuses the LP structures and change_form functions that were present. However, the strategy from building a model from an LP structure is different. Instead of having a custom function that creates an MOIU model from an LP structure, the LP structures are now sub-types of MOI.ModelLike and they implement the read-only MOI API. It also fills up some tests and the README to make it ready for users to start to play with it. It still does not cover the use case of users wanting to extract a matrix form from a JuMP or MOI model but that is left as future work :)

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@de6863d). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   86.14%           
=========================================
  Files             ?        3           
  Lines             ?      166           
  Branches          ?        0           
=========================================
  Hits              ?      143           
  Misses            ?       23           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de6863d...e17450a. Read the comment docs.