search

jump-dev / MatrixOptInterface.jl

An interface to pass matrix form problems
MIT License
11 stars 4 forks source link

Remove get_conic_form and add sparse conversion #21

Closed blegat closed 3 years ago

blegat commented 3 years ago

Should allow to get rid of https://github.com/jump-dev/DiffOpt.jl/blob/1f05b57910642a858f2edfed32c0d26cacc3d80a/src/utils.jl#L153-L164

codecov[bot] commented 3 years ago

Codecov Report

Merging #21 (be74117) into master (2f9b11b) will increase coverage by 2.66%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   82.72%   85.38%   +2.66%     
==========================================
  Files           5        5              
  Lines         272      308      +36     
==========================================
+ Hits          225      263      +38     
+ Misses         47       45       -2
Impacted Files Coverage Δ
src/conic_form.jl 76.84% <75.00%> (-1.18%) :arrow_down:
src/sparse_matrix.jl 100.00% <100.00%> (+20.00%) :arrow_up:
src/matrix_input.jl 98.75% <0.00%> (+0.33%) :arrow_up:
src/change_form.jl 77.10% <0.00%> (+3.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f9b11b...17d695c. Read the comment docs.