search

jump-dev / MatrixOptInterface.jl

An interface to pass matrix form problems
MIT License
11 stars 4 forks source link

uniform sense, documentation #23

Closed matbesancon closed 3 years ago

matbesancon commented 3 years ago

We should get the habit of documenting the code, at least docstrings

matbesancon commented 3 years ago

Potentially breaking: homogeneized the optimization sense to "sense" as a field name in structs

codecov[bot] commented 3 years ago

Codecov Report

Merging #23 (8ced00e) into master (d56c4aa) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files           5        5           
  Lines         316      316           
=======================================
  Hits          271      271           
  Misses         45       45
Impacted Files Coverage Δ
src/change_form.jl 77.10% <ø> (ø)
src/conic_form.jl 76.84% <100.00%> (ø)
src/matrix_input.jl 98.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d56c4aa...8ced00e. Read the comment docs.

matbesancon commented 3 years ago

(I can't merge things I don't have the rights on the repo)