Closed frapac closed 3 years ago
Merging #28 (7c26c3e) into master (4652d04) will increase coverage by
0.68%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 85.80% 86.48% +0.68%
==========================================
Files 5 5
Lines 317 333 +16
==========================================
+ Hits 272 288 +16
Misses 45 45
Impacted Files | Coverage Δ | |
---|---|---|
src/conic_form.jl | 77.77% <100.00%> (+0.69%) |
:arrow_up: |
src/matrix_input.jl | 98.82% <100.00%> (+0.07%) |
:arrow_up: |
src/sparse_matrix.jl | 100.00% <100.00%> (ø) |
|
src/MatrixOptInterface.jl | 87.50% <0.00%> (-0.50%) |
:arrow_down: |
src/change_form.jl | 78.16% <0.00%> (+1.05%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4652d04...7c26c3e. Read the comment docs.
Remove
MOI.set(model, MOI.ConstraintName(), MOI.ConstraintIndex{MOI.VariableIndex, MOI.GreaterThan{Float64}}.(1:2), vcon_names)
and do
MOIT.util_test_models_equal(model, expected, var_names, con_names)
We dropped names for VariableIndex
constraints.
Indeed, that solves the issue. Thanks for the pointer!
All tests are passing, except this one:
The problem is that
VariableIndex
does not supportConstraintName
(whereas previously,SingleVariable
does). Not sure what exactly to do about that.