Open joaquimg opened 1 year ago
related to https://github.com/jump-dev/MathOptInterface.jl/issues/1940
@odow, we should only support MOI to a single LP form. The other conversions should follow from that point.
@blegat, currently the conic geometric form is very flexible here. a change to MatrixOfConstraints would limit the available sets to a fixed subset, right? Have you thought about that?
I think MatrixOptInterface should do the matrix conversion to MOI both ways. Before this PR, it was able to do 1 - MOI to matrix for conic programs 2 - matrix to MOI for linear programs
after this, MatOI will be able to do 3 - MOI to matrix for linear programs
it will be missing: 4 - matrix to MOI for conic programs
currently the conic geometric form is very flexible here. a change to MatrixOfConstraints would limit the available sets to a fixed subset, right? Have you thought about that?
We can move https://github.com/jump-dev/DiffOpt.jl/blob/master/src/product_of_sets.jl to this repo and use it for the conic version.
Codecov Report
Base: 87.25% // Head: 88.94% // Increases project coverage by
+1.68%
:tada:Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #32 +/- ## ========================================== + Coverage 87.25% 88.94% +1.68% ========================================== Files 5 6 +1 Lines 361 416 +55 ========================================== + Hits 315 370 +55 Misses 46 46 ``` | [Impacted Files](https://codecov.io/gh/jump-dev/MatrixOptInterface.jl/pull/32?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jump-dev) | Coverage Δ | | |---|---|---| | [src/MatrixOptInterface.jl](https://codecov.io/gh/jump-dev/MatrixOptInterface.jl/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jump-dev#diff-c3JjL01hdHJpeE9wdEludGVyZmFjZS5qbA==) | `88.46% <ø> (ø)` | | | [src/matrix\_input.jl](https://codecov.io/gh/jump-dev/MatrixOptInterface.jl/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jump-dev#diff-c3JjL21hdHJpeF9pbnB1dC5qbA==) | `99.05% <100.00%> (+0.04%)` | :arrow_up: | | [src/moi\_to\_lp.jl](https://codecov.io/gh/jump-dev/MatrixOptInterface.jl/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jump-dev#diff-c3JjL21vaV90b19scC5qbA==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jump-dev). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jump-dev):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.