Closed zengjian-hu-rai closed 1 year ago
Patch coverage: 100.00%
and project coverage change: +0.05%
:tada:
Comparison is base (
8574b83
) 97.32% compared to head (4acf817
) 97.37%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Quite a few change suggestions, but all stemming from the high-level comment:
- Let's just have one
num_solutions
option, store it in theoptions
dictionary, and always add it to the command line args.
Thanks for the great suggestions! Hopefully I've addressed them all.
Okay, I added a bunch more changes. But this looks good now. Let me know if you're still happy and I'll merge.
Yes it looks great! thanks so much for polishing!
thanks so much for polishing!
No problem. Sorry for being somewhat pedantic, but I hope you'll agree it looks a lot tidier now.
thanks so much for polishing!
No problem. Sorry for being somewhat pedantic, but I hope you'll agree it looks a lot tidier now.
Yes it does, thanks again.
Add option num_solutions
num_solutions will be default to 1, unless it's set explicitly
Changed primal_solution to primal_solutions to hold 1+ solutions
Modified MOI.ResultCount, MOI.TerminationStatus.
If num_solutions > 1 and we've found the given number of solutions, return MOI.SOLUTION_LIMIT, otherwise MOI.OPTIMAL