search

jump-dev / MutableArithmetics.jl

Interface for arithmetics on mutable types in Julia
Mozilla Public License 2.0
50 stars 8 forks source link

Fix product of Complex with Hermitian #265

Closed blegat closed 8 months ago

blegat commented 8 months ago

The product of a Complex number with an Hermitian matrix is not an Hermitian matrix. We should probably still

before we merge

Closes https://github.com/jump-dev/MutableArithmetics.jl/issues/264

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.07%. Comparing base (ccaa222) to head (168068a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #265 +/- ## ========================================== + Coverage 90.95% 91.07% +0.12% ========================================== Files 23 23 Lines 2167 2163 -4 ========================================== - Hits 1971 1970 -1 + Misses 196 193 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

odow commented 8 months ago

This method was never tested:

image

I think because we don't have a way to test Complex{<:AbstractMutable}, because Complex{T} requires T<:Real and !(AbstractMutable <: Real).