search

jump-dev / NLopt.jl

A Julia interface to the NLopt nonlinear-optimization library
https://nlopt.readthedocs.io/en/latest/
Other
265 stars 46 forks source link

predeclare global used in extension #211

Closed palday closed 10 months ago

palday commented 10 months ago

potentially fixes #210

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (063615b) 68.46% compared to head (b32d892) 68.46%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #211 +/- ## ======================================= Coverage 68.46% 68.46% ======================================= Files 2 2 Lines 799 799 ======================================= Hits 547 547 Misses 252 252 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ericphanson commented 10 months ago

this is the same as https://github.com/JuliaOpt/NLopt.jl/pull/206 fyi

palday commented 10 months ago

Looking at the comments in #206, I saw that there were some thoughts on the impact of a non-const global. I think that issue existed even before now, but we can add a type-annotation to the global (all Julia versions which support extensions also support type annotations on globals), which will reduce some of the impact there.

montyvesselinov commented 10 months ago

are you going to merge and release a new version?

stevengj commented 10 months ago

Thanks for the reminder: https://github.com/JuliaRegistries/General/pull/98576

bclyons12 commented 10 months ago

@stevengj Just FYI, looks like the the new release version got hung up and won't be released automatically.

stevengj commented 10 months ago

https://github.com/JuliaRegistries/General/pull/98655