search

jump-dev / Pajarito.jl

A solver for mixed-integer convex optimization
Mozilla Public License 2.0
131 stars 22 forks source link

in MSD, if oa soln is infeas but no cuts added, must terminate #373

Closed chriscoey closed 7 years ago

chriscoey commented 7 years ago

fixes #366

codecov[bot] commented 7 years ago

Codecov Report

Merging #373 into master will increase coverage by 0.54%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   91.34%   91.89%   +0.54%     
==========================================
  Files           4        4              
  Lines        1687     1690       +3     
==========================================
+ Hits         1541     1553      +12     
+ Misses        146      137       -9
Impacted Files Coverage Δ
src/conic_algorithm.jl 92.41% <100%> (+0.78%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4841c3...1c91ac8. Read the comment docs.

mlubin commented 7 years ago

I'm not convinced that this needs to apply when we're using separation cuts. We'll have to see if this comes up on any instances that would've otherwise been optimal.