refactor violation functions for nonlinear cones

[chriscoey]

fixes #369 fixes #370

[chriscoey]

still working on the other two cones

[codecov[bot]]

Codecov Report

Merging #374 into master will increase coverage by <.01%. The diff coverage is 95.65%.

@@            Coverage Diff            @@
##           master    #374      +/-   ##
=========================================
+ Coverage   91.89%   91.9%   +<.01%     
=========================================
  Files           4       4              
  Lines        1690    1692       +2     
=========================================
+ Hits         1553    1555       +2     
  Misses        137     137

Impacted Files	Coverage Δ
src/conic_algorithm.jl	92.42% <95.65%> (+0.01%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbcb658...3fa0c05. Read the comment docs.

[codecov[bot]]

Codecov Report

Merging #374 into master will increase coverage by <.01%. The diff coverage is 95.65%.

@@            Coverage Diff            @@
##           master    #374      +/-   ##
=========================================
+ Coverage   91.89%   91.9%   +<.01%     
=========================================
  Files           4       4              
  Lines        1690    1692       +2     
=========================================
+ Hits         1553    1555       +2     
  Misses        137     137

Impacted Files	Coverage Δ
src/conic_algorithm.jl	92.42% <95.65%> (+0.01%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbcb658...3fa0c05. Read the comment docs.