search

jump-dev / Pajarito.jl

A solver for mixed-integer convex optimization
Mozilla Public License 2.0
131 stars 22 forks source link

Linear instead of All-NonLinear #393

Closed Wikunia closed 6 years ago

Wikunia commented 6 years ago

The sparse matrix should use the number of linear constraints in my opinion instead of all constraints - the non linear ones. Makes it easier to read and the variable is already defined.

codecov[bot] commented 6 years ago

Codecov Report

Merging #393 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files           4        4           
  Lines        1717     1717           
=======================================
  Hits         1555     1555           
  Misses        162      162
Impacted Files Coverage Δ
src/nonlinear_algorithm.jl 92.73% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 34b61db...e46b9a8. Read the comment docs.

chriscoey commented 6 years ago

Thanks :+1: There are lots of changes one could make to nonlinear_algorithm.jl to make it clearer :smile: Probably it will/should be rewritten at some point, not sure by whom though. There will be some important changes to MathProgBase and JuMP soon (3-6 months?) so it would make sense for it to happen after that.