search

jump-dev / Pajarito.jl

A solver for mixed-integer convex optimization
Mozilla Public License 2.0
129 stars 22 forks source link

v0.6/v0.7/v1.0 Support #421

Closed ccoffrin closed 5 years ago

ccoffrin commented 5 years ago

Currently this PR is for a preliminary code review, while we wait for dependent packages to be tagged.

@chriscoey, has requested to move from time_ns() to time()

chriscoey commented 5 years ago

failing on 1.0

ccoffrin commented 5 years ago

It is not expected that CI will pass until the dependent libs have been tagged and these packages updated. Current blocking issue is https://github.com/JuliaLang/METADATA.jl/pull/19070

codecov[bot] commented 5 years ago

Codecov Report

Merging #421 into master will increase coverage by 1.08%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   89.03%   90.12%   +1.08%     
==========================================
  Files           3        4       +1     
  Lines        1322     1326       +4     
==========================================
+ Hits         1177     1195      +18     
+ Misses        145      131      -14
Impacted Files Coverage Δ
src/Pajarito.jl 0% <0%> (ø)
src/solver.jl 73.46% <0%> (ø) :arrow_up:
src/conic_algorithm.jl 91.43% <90.09%> (+1.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca147a3...d2b55e5. Read the comment docs.

ccoffrin commented 5 years ago

@chriscoey @mlubin I think I got all of the revision requests. All tests passing locally, just waiting on JuliaLang/METADATA.jl#19070 to finalize.

chriscoey commented 5 years ago

LGTM. thanks!!