search

jump-dev / Pajarito.jl

A solver for mixed-integer convex optimization
Mozilla Public License 2.0
129 stars 22 forks source link

don't run SCS for SOC and Exp+SOC conic tests #435

Closed chriscoey closed 4 years ago

chriscoey commented 4 years ago

ECOS already covers these cases

hopefully fixes #434

codecov[bot] commented 4 years ago

Codecov Report

Merging #435 into master will decrease coverage by 1.27%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   90.42%   89.15%   -1.28%     
==========================================
  Files           4        4              
  Lines        1326     1272      -54     
==========================================
- Hits         1199     1134      -65     
- Misses        127      138      +11
Impacted Files Coverage Δ
src/conic_algorithm.jl 90.33% <0.00%> (-1.43%) :arrow_down:
src/solver.jl 73.33% <0.00%> (-0.14%) :arrow_down:
src/conic_dual_solver.jl 66.66% <0.00%> (+1.28%) :arrow_up:
src/Pajarito.jl 33.33% <0.00%> (+33.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3337301...d206371. Read the comment docs.