search

jump-dev / Pajarito.jl

A solver for mixed-integer convex optimization
Mozilla Public License 2.0
129 stars 22 forks source link

Fix failing test by bounding SOS variables #453

Closed odow closed 5 months ago

odow commented 5 months ago

Closes #452

The new SOS to MILP bridge works only if the variables are finitely bounded.

odow commented 5 months ago

Ah. Pajarito doesn't actually pass variable bounds to the MIP solver. That seems like a design to be fixed.

odow commented 5 months ago

I don't think we can ever have tested SOS constraints because GLPK doesn't support them.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4c7efa9) 89.89% compared to head (e726d79) 90.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #453 +/- ## ========================================== + Coverage 89.89% 90.12% +0.23% ========================================== Files 12 13 +1 Lines 1029 1033 +4 ========================================== + Hits 925 931 +6 + Misses 104 102 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.