Closed odow closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.92%. Comparing base (
4ec565a
) to head (ec7ed41
).:exclamation: Current head ec7ed41 differs from pull request most recent head 343f7b3
Please upload reports for the commit 343f7b3 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
1 - Is there a tutorial using NLP parameters? 2 - In theory, we could preprocess the new nonlinear expression for VariableRef-in-MOI.Parameter, but it might be messy, correct?
MOI.ScalarNonlinearFunction
. The issue is that we can't rewrite NLPBlock
.Bump. I get that this is breaking, but the previous approach was incorrect and can't be worked around.
Lets merge this
Closes https://github.com/jump-dev/ParametricOptInterface.jl/issues/146 Closes #149
We actually don't support the
NLPBlock
because POI re-orders the variables by removing parameters. The tests passed because they had parameters at the end. But that isn't a good solution, and it seems simpler to drop support for the legacy nonlinear interface than throw an error if parameters are not in the right order.We also don't really need POI for nonlinear. Ipopt supports parameters directly.