search

jump-dev / Pavito.jl

A gradient-based outer approximation solver for convex mixed-integer nonlinear programming (MINLP)
Other
60 stars 10 forks source link

Large refactoring of the tests #52

Closed odow closed 2 years ago

odow commented 2 years ago

This PR gets rid of all of the non-const global state, encapsulates each test into a function, and removes the import_solvers.jl stuff. We now only test with GLPK and Ipopt, but it's easy to swap out the solvers with commercial ones if you want on your local machine.

codecov[bot] commented 2 years ago

Codecov Report

Merging #52 (9e37a7f) into master (2ee4422) will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   86.24%   86.22%   -0.02%     
==========================================
  Files           4        4              
  Lines         625      704      +79     
==========================================
+ Hits          539      607      +68     
- Misses         86       97      +11
Impacted Files Coverage Δ
src/optimize.jl 84.49% <0.00%> (+0.40%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ee4422...9e37a7f. Read the comment docs.

odow commented 2 years ago

Merging so I can take a look at some of the excluded tests. The MINLPTest failures in particular are worrying and suggestive of some major bugs.