search

jump-dev / Xpress.jl

A Julia interface to the FICO Xpress Optimization suite
https://www.fico.com/en/products/fico-xpress-optimization
65 stars 30 forks source link

Update wrapper of xprs.h #257

Closed odow closed 5 months ago

odow commented 5 months ago

I need to figure out a good way of handling the variety of Xpress versions that people might use.

I have headers for v33.01.12 and v42.01.05. Ideally, the Xpress.jl should use only functions defined in v33, but it should provide constants etc for v42.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.93%. Comparing base (5eb8119) to head (209c78b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #257 +/- ## ========================================== + Coverage 67.91% 67.93% +0.01% ========================================== Files 6 6 Lines 3301 3303 +2 ========================================== + Hits 2242 2244 +2 Misses 1059 1059 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

odow commented 5 months ago

I think this really highlights that we should have some way of testing v8

odow commented 5 months ago

x-ref https://github.com/JuliaRegistries/General/pull/103626

odow commented 5 months ago

Okay. I'm feeling a lot better about this now that we're testing on v8 and v9.

odow commented 5 months ago

Merging because I want to open a couple of follow-ups.