search

jump-sdk / jetpack_compose_country_code_picker_emoji

Jetpack Compose Country Code Picker with Emoji Flags
https://jitpack.io/#jump-sdk/jetpack_compose_country_code_picker_emoji
Apache License 2.0
45 stars 13 forks source link

Feat/keyboard customization #27

Closed itstanany closed 9 months ago

itstanany commented 9 months ago
sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

itstanany commented 9 months ago

What is the usecase for this? i.e. what behavior changes are needed for your usecase?

Please remove commented out code.

  • Ok, i will do,
  • but I think your suggestion about using null as a defult value for these parameters at function signature and use the pre-modification behvior in case client code doesn't pass values for these parameters is a better approach
itstanany commented 9 months ago

I will close this pull request in fovor of a new PR #35 with same functionality and modifications suggested by @hbmartin