jump-sdk / jetpack_compose_country_code_picker_emoji

Jetpack Compose Country Code Picker with Emoji Flags
https://jitpack.io/#jump-sdk/jetpack_compose_country_code_picker_emoji
Apache License 2.0
45 stars 13 forks source link

Refactoring Country Data #32

Closed hbmartin closed 9 months ago

hbmartin commented 9 months ago

I started pulling on a thread where passing in an initial country code might result in the wrong country showing (since multiple countries can potentially share the same numerical code). I ended up refactoring the internal data model and think this lands on something much cleaner and easier to work with going forward.

hbmartin commented 9 months ago

@tanany365 this modifies some of the parameter names from https://github.com/jump-sdk/jetpack_compose_country_code_picker_emoji/pull/26 to hopefully make them more clear, lmk what you think.

itstanany commented 9 months ago

Great work @hbmartin , Names are more clear now 👓🥽 Also typealiases are insightful ☘ We will work to make it better and better

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication