search

jump-sdk / jetpack_compose_country_code_picker_emoji

Jetpack Compose Country Code Picker with Emoji Flags
https://jitpack.io/#jump-sdk/jetpack_compose_country_code_picker_emoji
Apache License 2.0
45 stars 13 forks source link

Free focus inside a coroutine scope #46

Closed ankur2136 closed 8 months ago

ankur2136 commented 8 months ago

Fixes #42

hbmartin commented 8 months ago

This is great! But I think the try/catch should be kept in place to prevent future regressions e.g. if the underlying FocusRequester implementation changes

hbmartin commented 8 months ago

It would be great to refactor TCCP a bit for brevity but you're welcome to suppress CognitiveComplexMethod for now

sonarcloud[bot] commented 8 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ankur2136 commented 8 months ago

It would be great to refactor TCCP a bit for brevity but you're welcome to suppress CognitiveComplexMethod for now

It's already suppressed on the method but somehow detekt isn't recognising it.