Closed ankur2136 closed 7 months ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Thank you! 🚀 🚀 🚀 I'll take a closer look soon. Wonder if there's a way to package this in another module to avoid needing to ship appcompat/play, I'll think about it over the weekend.
Thank you! 🚀 🚀 🚀 I'll take a closer look soon. Wonder if there's a way to package this in another module to avoid needing to ship appcompat/play, I'll think about it over the weekend.
I've verified that adding the play-services-auth
library is not making any difference in the lib size.
App compat addition is only to fix one of the warnings from sonar which is not a bug but a misconfigured version. (https://stackoverflow.com/a/66740530). The app works the exact same way even without adding the dependency.
It would be easier if we can merge these changes, then split the whole code into a few modules
play-services-auth
-- As a developer consuming this library, I wouldn't be worried given this is optional and would be stripped out by proguard if not used. Closing since it seems no one wants to merge this.
These first 2 screen shots show how the dialog pops up and use can choose to select their verified phone numbers.
Fix the country code selector to auto-change to autofilled phone number Instead of filling just the
PhoneNumberNation
, the changes would auto-populate the country code from the filled number See screenshot1 and 2 for reference where original selected country was India but the autofill populated a number starting +1-858 ... which changed the country code to +1 (US)If the user dismisses the first bottomsheet, then a regular keyboard with autofill is triggered. (Screenshot3)
which also suggests an autofill number (this was the original implementation) Selecting this number also leads to the same result on screenshot2 which autofills the phone number as well as country code.
Followup:
as you type number's
country code parsing.