A PR that's an issue - Githubissues

jumpingrivers / HIBPwned

R Package 📦 for using the HaveIBeenPwned.com API :scream:

http://jumpingrivers.github.io/HIBPwned/

Other

13 stars 4 forks source link

A PR that's an issue #1

Closed Ironholds closed 7 years ago

Ironholds commented 7 years ago

Opening this as a pull request because you don't have issues enabled; one of this package's unit tests breaks with the API changes in the new urltools release (I have...literally no idea why). But if you install urltools from github and run the tests, you'll see what I mean. I can't release until this is fixed, so it'd be great if y'all could work out what's going on (and let me know if it's an issue at my end).

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 74feb9ea1f46dc058686cdff7ae07cde4cffb6c5 on Ironholds:patch-1 into b4ddf08595b777d71f4f69c6ae07ad835ffe6345 on censornet:master.

stephlocke commented 7 years ago

This is really mother fungling weird with the new version of urltools only.

library(devtools)
load_all()
breached_sites()
breached_sites("xyz.com")
breached_sites()

Run from scratch I get what I'd expect Then if I run it for the domain used in my test, it works If I go back to a NULL domain I get xyz.com again

Could it be some sort of issue with the memory being held for the variable URLs where it's getting params etc?