search

jumpingrivers / HIBPwned

R Package 📦 for using the HaveIBeenPwned.com API :scream:
http://jumpingrivers.github.io/HIBPwned/
Other
13 stars 4 forks source link

Output of account_breaches #5

Closed maelle closed 6 years ago

maelle commented 6 years ago

The function currently returns a list of data.frames. Should they be a single data.frame with an email address variable instead?

stephlocke commented 6 years ago

There's info on each breach split by name iirc - if you think it'd be easier to consume as a single table with the breach info and which email was breached (which you're probably right about!) then go for it. Will probably need to make things super clear that this is a breaking change - and/or have a flag for using the old behaviour.