Various improvements - Githubissues

jumpingrivers / HIBPwned

R Package 📦 for using the HaveIBeenPwned.com API :scream:

http://jumpingrivers.github.io/HIBPwned/

Other

13 stars 4 forks source link

Various improvements #8

Closed maelle closed 6 years ago

maelle commented 6 years ago

Next time I should try to use gitflow. 👼

I am not able yet to reproduce the error from CRAN 😢 In the latest Travis build the failing job is the one on R devel on OSX... https://travis-ci.org/maelle/HIBPwned/builds/356264582
I have added some trying and waiting in utils.R
I have added grouping to the reference in the pkgdown website
I have taken the freedom to use styler and lintr to mostly shorten lines, add space, and rename "URLS" to "urls" (I added exceptions for non snake case function names)

maelle commented 6 years ago

I could tacke #5 (breaking change though...) and #6 if you agree with them.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 80199eec858c18bb32fa33c835e57e23001332d2 on maelle:master into 8f6e86cb472ffc05a1db8fce879ef93352003589 on stephlocke:master.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 80199eec858c18bb32fa33c835e57e23001332d2 on maelle:master into 8f6e86cb472ffc05a1db8fce879ef93352003589 on stephlocke:master.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling b0059ba50963c9a7b844a8cd59432be0faa39744 on maelle:master into 8f6e86cb472ffc05a1db8fce879ef93352003589 on stephlocke:master.

stephlocke commented 6 years ago

I keep URLS uppercase as it avoids naming collisions with some functions that exist in different packages. I'd prefer it to stay as is if that's ok.

maelle commented 6 years ago

This could be merged but I still get a failing build on OSX R devel (see this log for instance) because of missing dependencies, and I still wasn't able to reproduce the CRAN error.

maelle commented 6 years ago

@stephlocke

Can I merge this? The failure on Mac R devel seems to be a Travis problem, not a R problem.
Does the package need anything more before the next CRAN release? this PR closes all 3 open issues, and the CRAN note will disappear.

stephlocke commented 6 years ago

Travis fail? https://travis-ci.org/stephlocke/HIBPwned/jobs/358321151 Is it possible to write a test for the get and retry funciton you made?

maelle commented 6 years ago

the Travis fail seems to be a Travis issue (it fails to install dependencies on Mac R devel). I could investigate it or remove the Mac R devel build from the matrix?

stephlocke commented 6 years ago

Yeah, I don't really care all that much about mac ;)