jumpingrivers / namer

R package :package: for labelling chunks of RMarkdown files! :boom:
https://jumpingrivers.github.io/namer/
Other
94 stars 11 forks source link

Add `unname_dir` and other changes #23

Closed pat-s closed 4 years ago

pat-s commented 5 years ago

NEWS.md needs to be updated with the PR number before merge.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 76


Changes Missing Coverage Covered Lines Changed/Added Lines %
R/name_chunks.R 3 6 50.0%
<!-- Total: 7 10 70.0% -->
Totals Coverage Status
Change from base Build 75: -2.4%
Covered Lines: 107
Relevant Lines: 113

💛 - Coveralls
maelle commented 4 years ago

:wave: @pat-s! Thanks for your PR! We'll get to this PR soon-ish, but after the patch release we'll do to fix CRAN results. Thanks for your patience.

maelle commented 4 years ago

Once the patch release is on CRAN, I'll merge this manually since I created too many conflicts. :-) (local checks ok).

maelle commented 4 years ago

@pat-s thanks a lot! :rocket: And sorry for the delay! :snail:

Side note for future contributions, please open issues first so you're sure to not open an PR for nothing.

pat-s commented 4 years ago

Thanks a lot @maelle!

Side note for future contributions, please open issues first so you're sure to not open an PR for nothing.

Will do!