search

jumpingrivers / namer

R package :package: for labelling chunks of RMarkdown files! :boom:
https://jumpingrivers.github.io/namer/
Other
94 stars 11 forks source link

Remove rmarkdown from dependencies #24

Closed stephlocke closed 4 years ago

stephlocke commented 4 years ago

https://github.com/lockedata/namer/blob/master/tests/testthat/test-unname_all_chunks.R

rmarkdown even as an optional dep is getting some flak from cran re: pandoc. If we can remove rmarkdown from our tests and our suggests, that'd be great.

maelle commented 4 years ago

but don't we want to be able to check we've generated a valid Rmd? If not on CRAN, everywhere else?

stephlocke commented 4 years ago

I'd rather it stay on CRAN by jettisoning the tests or finding some other way to check validity. The alternative is maintaining system dependencies for pandoc etc. The situation is ludicrous given the sys deps are in an upstream package and it's optional but I don't think they'd accept them being skipped with on_cran checks.

stephlocke commented 4 years ago

We can give #25 a submission on Monday and see if the capricious powers that be accept it.