RTL Support in Sidebar Template

nimcnaan commented 2 years ago

There is an issu in RTL support in lagend, for external layers - attached image External Base RTL

jumpinjackie commented 2 years ago

A lot of mapguide-react-layout has not been tested for RTL compatibility. I also don't have much experience in making user interfaces RTL-friendly due to lack of exposure to RTL languages when doing i18n work.

Having said that, this is something that should be addressed, but I will need your comments and feedback in this thread as I work on this issue to see if I am doing RTL correctly. Watch this space!

jumpinjackie commented 2 years ago

Also did you have to make any changes to the viewer to get the above screenshot @nimcnaan ?

I need to know what is my starting point for adding RTL support. If you had to make changes the get the above, I need to know what those changes are.

jumpinjackie commented 2 years ago

Initial plan of attack:

[ ] Introduce a global RTL flag into application state. On viewer init, set this to true based on any of the following:
- The <html> element has a rtl attribute
- The viewer is initialized with a locale that is based on a RTL language (eg. Hebrew, Arabic)
[ ] Add a hook to easily fetch the RTL flag
Base Layer Switcher
- [ ] Add RTL mode as a prop. If true, render UI in RTL
Legend
- [ ] Add RTL mode as a prop. If true, render < instead of > for collapsed nodes
RTL-ize our various components
- List TBD

nimcnaan commented 2 years ago

You'll get full cooperation from us, even RDP access to our testing server. if 1 needed

‫בתאריך יום ג׳, 19 ביולי 2022 ב-12:21 מאת ‪Jackie Ng‬‏ <‪ @.***‬‏>:‬

A lot of mapguide-react-layout has not been tested for RTL compatibility. I also don't have much experience in making user interfaces RTL-friendly due to lack of exposure to RTL languages when doing i18n work.

Having said that, this is something that should be addressed, but I will need your comments and feedback in this thread as I work on this issue to see if I am doing RTL correctly. Watch this space!

— Reply to this email directly, view it on GitHub https://github.com/jumpinjackie/mapguide-react-layout/issues/1405#issuecomment-1188812334, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ5FU2ZCQOR4LRZ72WVPPGLVUZXSPANCNFSM537BVXNQ . You are receiving this because you authored the thread.Message ID: @.***>

--

בכבוד רב,

*נמרוד כנען | גיאומינד שירותי GIS – פיתוח, ייעוץ ושירותי ענן ישיר: 048101268 | נייד: 0525355483 | @.

נא בקרו באתר החדש שלנו http://geomind.co.il

nimcnaan commented 2 years ago

I'm not sore I understand what u 'r asking. I assume u meen my browser lang settings.

[image: image.png]

‫בתאריך יום ג׳, 19 ביולי 2022 ב-12:29 מאת ‪Jackie Ng‬‏ <‪ @.***‬‏>:‬

Also did you have to make any changes to the viewer to get the above screenshot @nimcnaan https://github.com/nimcnaan ?

I need to know what is my starting point for adding RTL support. If you had to make changes the get the above, I need to know what those changes are.

— Reply to this email directly, view it on GitHub https://github.com/jumpinjackie/mapguide-react-layout/issues/1405#issuecomment-1188821129, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ5FU25WFB45YTWVYGJ6WT3VUZYQBANCNFSM537BVXNQ . You are receiving this because you were mentioned.Message ID: @.***>

--

בכבוד רב,

*נמרוד כנען | גיאומינד שירותי GIS – פיתוח, ייעוץ ושירותי ענן ישיר: 048101268 | נייד: 0525355483 | @.

נא בקרו באתר החדש שלנו http://geomind.co.il

jumpinjackie commented 2 years ago

I'm not sore I understand what u 'r asking. I assume u meen my browser lang settings.

Let's put it this way then. If your browser language is hebrew, does it automatically make everything RTL?

nimcnaan commented 2 years ago

No, It doesn't

[image: image.png]

‫בתאריך יום ג׳, 19 ביולי 2022 ב-16:50 מאת ‪Jackie Ng‬‏ <‪ @.***‬‏>:‬

I'm not sore I understand what u 'r asking. I assume u meen my browser lang settings.

Let's put it this way then. If your browser language is hebrew, does it automatically make everything RTL?

— Reply to this email directly, view it on GitHub https://github.com/jumpinjackie/mapguide-react-layout/issues/1405#issuecomment-1189079968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ5FU22X63WWNYW6QWQFQHLVU2XB3ANCNFSM537BVXNQ . You are receiving this because you were mentioned.Message ID: @.***>

--

בכבוד רב,

*נמרוד כנען | גיאומינד שירותי GIS – פיתוח, ייעוץ ושירותי ענן ישיר: 048101268 | נייד: 0525355483 | @.

נא בקרו באתר החדש שלנו http://geomind.co.il

jumpinjackie commented 2 years ago

I don't understand how you got that screenshot. The viewer currently does not present UI in RTL layout unless there is a higher-level browser/OS/language setting I do not know about that is causing this. I need to know what that is.

nimcnaan commented 2 years ago

The RTL Version is from an MVC App, that chackes your LOCAL, If (Localize = HE) { then ....

[image: image.png]

‫בתאריך יום ג׳, 19 ביולי 2022 ב-17:16 מאת ‪Jackie Ng‬‏ <‪ @.***‬‏>:‬

I don't understand how you got that screenshot. The viewer currently does not present UI in RTL layout unless there is a higher-level browser/OS/language setting I do not know about that is causing this. I need to know what that is.

— Reply to this email directly, view it on GitHub https://github.com/jumpinjackie/mapguide-react-layout/issues/1405#issuecomment-1189110304, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ5FU25CXKK2UYHIZB3O3CDVU22CJANCNFSM537BVXNQ . You are receiving this because you were mentioned.Message ID: @.***>

--

בכבוד רב,

*נמרוד כנען | גיאומינד שירותי GIS – פיתוח, ייעוץ ושירותי ענן ישיר: 048101268 | נייד: 0525355483 | @.

נא בקרו באתר החדש שלנו http://geomind.co.il

jumpinjackie / mapguide-react-layout

RTL Support in Sidebar Template #1405