search

jumpsuit / jumpstate

Jumpstate is a simple and powerful state management utility for Redux.
MIT License
425 stars 22 forks source link

Script test wont run unit tests if there are lint errors #14

Closed sirgallifrey closed 7 years ago

sirgallifrey commented 7 years ago

When I run yarn test linter is executed but not unit tests. That happens because test:linter exits with code 1 and then npm-run-all exits too. I don't know it this is expected or not, but I expected that unit tests where executed independent of linting errors. This can be solved by placing a -c flag on npm-run-all command. I can PR that

tannerlinsley commented 7 years ago

Sounds good On Tue, Dec 20, 2016 at 5:00 PM Adilson Schmitt Junior < notifications@github.com> wrote:

When I run yarn test linter is executed but not unit tests. That happens because test:linter exits with code 1 and then npm-run-all exits too. I don't know it this is expected or not, but I expected that unit tests where executed independent of linting errors. This can be solved by placing a -c flag on npm-run-all command. I can PR that

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jumpsuit/jumpstate/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AFUmCVwp5KI9I8dB8hTKvEaGNJ_zZOiTks5rKGwmgaJpZM4LSbrw .