search

jumpsuit / jumpstate

Jumpstate is a simple and powerful state management utility for Redux.
MIT License
425 stars 22 forks source link

Make unit tests run despite linting errors. closes #14 #15

Closed sirgallifrey closed 7 years ago

sirgallifrey commented 7 years ago

Now unit tests are run whenever there are lint erros or not.

tannerlinsley commented 7 years ago

So this will still fail a test if linting fails but unit tests pass? On Tue, Dec 20, 2016 at 5:08 PM Adilson Schmitt Junior < notifications@github.com> wrote:

Now unit tests are run whenever there are lint erros or not.

You can view, comment on, or merge this pull request online at:

https://github.com/jumpsuit/jumpstate/pull/15 Commit Summary

  • make unit tests run despite linting errors. closes #14

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jumpsuit/jumpstate/pull/15, or mute the thread https://github.com/notifications/unsubscribe-auth/AFUmCWmcXXDD0aAzgfWBgRNTdhoJWLIPks5rKG3ogaJpZM4LSb9Q .

sirgallifrey commented 7 years ago

No, the tests will pass and the lint will show it's errors. They are different things. A code reviewer can still run yarn test and see passing tests and linting erros and then reject the PR if he sees fit.

Without the -c flag, if you put an unnecessary semicolon at the end of a statement (which will cause an lint error) the unity tests will not even run, so you will not know the tests results unless you fix the linting or you run unity tests directly with yarn tests:unit