The friends status error in the last version r368

[GoogleCodeExporter]

BUG REPRODUCE STEPS:
1, All of the offline friend's status is 
" is offline, can't receive you sms immediately, your msg will be saved and
sent later".
2: but V1.0 is OK.

EXPECTED OUTCOME:
show the right status.

ACTUAL OUTCOME:

LIBFETION VERSION:
OS: linux

OTHERS:

Original issue reported on code.google.com by libfet...@gmail.com on 3 Sep 2009 at 3:30

[GoogleCodeExporter]

This problem was caused by r343-r345.
I will fix it ASAP.

Original comment by libfet...@gmail.com on 3 Sep 2009 at 4:34

[GoogleCodeExporter]

probably a translation problem? 

Original comment by alsor.zhou on 3 Sep 2009 at 4:38

[GoogleCodeExporter]

Yes. :-)

Original comment by libfet...@gmail.com on 3 Sep 2009 at 5:25

[GoogleCodeExporter]

Yeah, I renamed some files, might forget to update in .ts:(

Original comment by alsor.zhou on 3 Sep 2009 at 5:34

[GoogleCodeExporter]

Did you means that this problem was caused by you?
O My God...

If you did, please help me to fix this problem. :-)

Original comment by libfet...@gmail.com on 3 Sep 2009 at 5:44

[GoogleCodeExporter]

Not sure~ lol~ I'll take a look at this later:) BTW, I think this issue is not a
blocker, reduce priority

Original comment by alsor.zhou on 3 Sep 2009 at 6:02

• Added labels: Priority-Medium, Usability
• Removed labels: Priority-Critical, Security

[GoogleCodeExporter]

Hi alsor,

How are going on this defect?
If the root cause is not triggered by you, please inform me, 
let me to solve it. 

Waiting for your feedback.

Original comment by libfet...@gmail.com on 14 Sep 2009 at 6:22

[GoogleCodeExporter]

Done, see r371. Actually, the root cause is the <'s offline> was transfer to <'s
offline> in .ts, which not march the original text.

The better way to solve this problem is, use some meta information instead of
original text, like
code: tr(_fx_contact_offline_msg_)
fetion_zh.ts: 
<source>_fx_contact_offline_msg_</source><translation>联系人不在线
</translation>
fetion_en.ts: <source>_fx_contact_offline_msg_</source><translation>Contact is
offline</translation>

Original comment by alsor.zhou on 14 Sep 2009 at 7:14

• Changed state: FIXED

[GoogleCodeExporter]

Ah, Thank you very much.

I am interested in how did you introduce "'" to replace "'" ?

Original comment by libfet...@gmail.com on 14 Sep 2009 at 7:20

[GoogleCodeExporter]

Not sure, it might be some "machine code":) AYK, we have use some tools to 
format the
codes style, it might be there. Who knows:) 

Original comment by alsor.zhou on 14 Sep 2009 at 7:29

[GoogleCodeExporter]

"it might be some "machine code""

O My God,
It seems that we need to assigned an specially person who do the job that 
updating
the "ts"/"qm" files to avoid this problem in future.

Original comment by libfet...@gmail.com on 14 Sep 2009 at 7:34

[GoogleCodeExporter]

Better to have it, generally, .ts has none business with logic/function, 
developers
just refer to the meta text, like "_fx_contact_offline_msg_" in my previous 
message. 

But, AYK, we don't have other man left...:( 

Original comment by alsor.zhou on 14 Sep 2009 at 7:40

[GoogleCodeExporter]

I think I can do it.~~~

heihei.

Original comment by libfet...@gmail.com on 14 Sep 2009 at 7:42

[GoogleCodeExporter]

:) OK, so, only you will maintain that .ts|qm file. 

BTW, would you take a look at comment 8? I think, that' the right way to do
localization. Think this use case, 
code: tr(" contact offline")
someone modify that by occasional, and it become to 
code: tr("  contact offline ")
It's not easy to find out such problem:)

Original comment by alsor.zhou on 14 Sep 2009 at 7:53

[GoogleCodeExporter]

Yes, In that case, it is hard to find out.

Do you have a good idea to handle this?

Original comment by libfet...@gmail.com on 14 Sep 2009 at 8:02

[GoogleCodeExporter]

How about this?

tr(" contact offline ") -> 

" " + tr("contact offline") + " " 

Original comment by libfet...@gmail.com on 14 Sep 2009 at 8:03

[GoogleCodeExporter]

No idea, I mess up with QT localization and other linux applications. comment8 
was
based on 'gettext' mechanism which conflict with QT's. So, just ignore that. 

IMHO, QT's tr system really sucks ass, refer
http://blog.venthur.de/2008/09/14/gettext-and-qt4/ for details..

Original comment by alsor.zhou on 14 Sep 2009 at 8:17

[GoogleCodeExporter]

Ok, finally, I got a workaround, put all the tr strings into a global header, 
such as
fxstrings.h
#define _contact_offline_msg_    "contact offline"
and use it in code: tr(_contact_offline_msg_), which compatible with linguist, 
and
more gettext like.

You might think it more:)

Original comment by alsor.zhou on 14 Sep 2009 at 9:29

[GoogleCodeExporter]

reopen.
This issues didn't been fixed...

Original comment by libfet...@gmail.com on 15 Sep 2009 at 1:48

• Changed state: STARTED

[GoogleCodeExporter]

add a fix r372.
Now, this defect was fixed completely.

Thanks for alsor.

Original comment by libfet...@gmail.com on 15 Sep 2009 at 3:03

• Changed state: FIXED