在windows上有些用户无法自定义字体 （v1.0）

[GoogleCodeExporter]

在windows上有些用户无法自定义字体 （v1.0）

需要看看是什么原因～～

其它信息：
http://libfetion.cn/bbs/viewthread.php?tid=1702&extra=page%3D1

Original issue reported on code.google.com by libfet...@gmail.com on 6 Jul 2009 at 1:46

[GoogleCodeExporter]

事实上在Ubuntu 9.10 
Karmic上面同样无法支持字体设置，我准备解决这个bug，然后��
�交，谢谢

Original comment by alsor.zhou on 27 Jul 2009 at 1:36

[GoogleCodeExporter]

Problem solved~ test passed in Ubuntu 9.10 Karmic, it seems the we have pass in 
the
wrong QWidget* parent, just use the default one. 

QFont QFontDialog::getFont ( bool * ok, const QFont & initial, QWidget * parent 
= 0 )
  [static]
This is an overloaded function.

Solution preview: <src/fxconfigDlg.cpp:: line 282>
//QFont font = QFontDialog::getFont(&ok,
//  Settings::instance().getCurrentFont(), this)
QFont font = QFontDialog::getFont(&ok, Settings::instance().getCurrentFont());

Original comment by alsor.zhou on 28 Jul 2009 at 4:15

[GoogleCodeExporter]

Hi, would you merge this to the mainstream?

Original comment by alsor.zhou on 29 Jul 2009 at 3:51

[GoogleCodeExporter]

Hi alsor,
I am so sorry for late response(I just come back from my vacation.)
If you are using SVN, you can commit it by yourself.
I will set you as committer now.

Original comment by libfet...@gmail.com on 4 Aug 2009 at 1:43

[GoogleCodeExporter]

Thanks Dongdong, I'll take this ticket.

Original comment by alsor.zhou on 4 Aug 2009 at 5:05

• Changed state: Accepted

[GoogleCodeExporter]

Reassign

Original comment by alsor.zhou on 4 Aug 2009 at 5:06

[GoogleCodeExporter]

void FxConfigDia::SetAllFont(const QFont & font) 's font setting should be 
completely
re-designed, hard code is not flexiable enough if UI changes.

Original comment by alsor.zhou on 4 Aug 2009 at 3:46

[GoogleCodeExporter]

Although those codes were write by me, I still say that: they are very very 
ugly. :)

Original comment by libfet...@gmail.com on 5 Aug 2009 at 1:59

[GoogleCodeExporter]

Cont discussing, I thought font change should *NOT* take effect on menu 
settings,
titles, icon text and other "application functional settings like" text. 
Compare with
QQ/Adium and other popular IMs, we can only change the text style in msg 
view/edit
area (see my attachment). That's because style change will effect the original
layout. That can not be accepted.

Dongdong, do you agree with that?

Original comment by alsor.zhou on 7 Aug 2009 at 7:10

Attachments:

• screenshot_004.png

[GoogleCodeExporter]

Hi alsor,

Most of user which were using vista, The default font of program on vista is too
small to use. So they want to change the default font.

Maybe we can offer two options.
1: set the app's font, which affect the whole program.
2: set the chat dialog's font which just affect chat info.

we can realize the 1 first,  we can realize the 2 when we have time.

Do you think about them?

Original comment by libfet...@gmail.com on 7 Aug 2009 at 7:31

[GoogleCodeExporter]

Sure, I forgot the user case you mentioned above. So, there should be 2 entries 
for
font setting, one for application wide (current font setting option in 
configDlg),
and the other for the chat window(new btn in chat window like QQ 'Font'). 
That's OK.

Accept.

Original comment by alsor.zhou on 7 Aug 2009 at 7:37

[GoogleCodeExporter]

Hi alsor,
It seems that your patch didn't really fix this problem on win32 platform.

Could you have an another patch for this issue?

BTW: I will try to fix it in the next few days.

Original comment by libfet...@gmail.com on 9 Aug 2009 at 8:37

[GoogleCodeExporter]

Just the title of program will change after we set font.

But the buddy list didn't change..

Original comment by libfet...@gmail.com on 9 Aug 2009 at 9:00

[GoogleCodeExporter]

Yes, truely, the font size and family did not changed, but italic does. I'll 
keep an
eye on that~ 

Original comment by alsor.zhou on 9 Aug 2009 at 12:43

[GoogleCodeExporter]

Reload stylesheet after set font can solve this problem(Look at r313 for 
details).
Since libfetion-gui used css for style/skin management after v1.0, it's 
un-necessary
to set fonts in each widgets.

Original comment by alsor.zhou on 17 Aug 2009 at 1:42

• Changed state: Fixed