jun7 / rox-filer

ROX file manager
24 stars 6 forks source link

background for jpeg thumbs from transparent png #123

Closed step- closed 8 years ago

step- commented 8 years ago

How can I set the default background color that is used to create JPG thumbnails? Currently it seems that the default background is black and cannot be changed (see screenshots). Enhancement request: please allow setting the custom background to be used for the transparency channel when JPG thumbs are created.

Below you can see three cases: 1) and 2) for jpeg thumbnails => black baground of mozilla.png and mtpaint.png icons => looks bad 3) png thumbails => alpha transparency => white (actual) background => looks good.

1. JPG thumbs, NO use custom background, with actual background white: 00002 00003 00004 2. JPG thumbs, YES use custom background, with actual background white: 00005 00006 3. PNG thumbs, NO use custom background, with actual background white: 00007 00008

jun7 commented 8 years ago

Jpeg hasn't alpha, so the black is may be set when created it. And I noticed that viewing icons as thumbs not matches slower and larger six times.

step- commented 8 years ago

Yes, black is set when jpeg thumb is created. Question is: can you set another background color; take background color from options?

And I noticed that viewing icons as thumbs not matches slower and larger six times.

But rox can't tell if png image file is for an icon or for a photo. I think rox should create jpeg thumbs with current list background color to replace transparent pixels.

jun7 commented 8 years ago

Ah sorry, I misunderstood it. hm, I think it is too mush work though I'll keep it in mind. thank you.

jun7 commented 8 years ago

There is gdk_pixbuf_get_has_alpha. So I will take this.

jun7 commented 8 years ago

I rethought of it, It has already an option that don't use jpeg, so It is too much work after all. Also the codes around thumbs are already too complex.

step- commented 8 years ago

OK, I understand. Thanks for considering it for awhile.