jun7 / wyeb

a vim-like webkit2gtk web browser
GNU General Public License v3.0
104 stars 6 forks source link

Link hints not showing up on heavy pages with opengl rendering #37

Closed sdsddsd1 closed 4 years ago

sdsddsd1 commented 4 years ago

Hello, wyeb´s link hints crashes when webkit2gtk is compiled with opengl and wpe-renderer. The hints are working on pages without javascript but when I visit a fancy site they dont apear anymore, although they remain functional. When I vist a simple page again, they dont show up until I restart wyeb. Webkit2gtk version: 2.28.2. Webkit2gtk compiled without opengl works just fine.

jun7 commented 4 years ago

Progress bar is drawn? (It uses same event and canvas) URI entry is drawn? (Other widgets on the web view are working?) Do the hints work without drawn? (only visibility?) Does the adblock work? (Other extensions are working?) Key "a" shows blocked resources? (Is the extension containing the hints working?)

jun7 commented 4 years ago

Ah is it default option?

sdsddsd1 commented 4 years ago

fancy=javascript and bling bling | simple=plain text

jun7 commented 4 years ago

I cant tell on simple sites because its loading too fast

Pointer Mode's "+" is drawn? (Pointer mode is assigned key 'p') It is also same as hints.

sdsddsd1 commented 4 years ago

It enters pointer mode, but no red dot is drawn.

jun7 commented 4 years ago

Is it fixed?

sdsddsd1 commented 4 years ago

No. Now the linkhints also dont show up on simple sites. Rest of the testings like above.

jun7 commented 4 years ago

I updated the commit. Is it fixed.

sdsddsd1 commented 4 years ago

Yibbie! Link hints are working now. Thanks for fixing this!
Windowswitcher widget now also pops on. One thing left is that the thumbnails from the history are not shown.
This is a minor thing and not important for me but I want to mention. screenshot

jun7 commented 4 years ago

Is the Windowswitcher key 'z' ? Is it normal? It uses same function as the history images.

sdsddsd1 commented 4 years ago

Yes this does the same "image".

jun7 commented 4 years ago

The commit kills drag and drop. So I will revert the commit and take another way.

sdsddsd1 commented 4 years ago

The last commit removed the link hints and status bar again. Images still corrupted.

jun7 commented 4 years ago

Hmm not reproduced. What is your build options of webkit2gtk? What is the fancy site?

sdsddsd1 commented 4 years ago

After your last commit the link hints are gone on every website. Also no progress bar or widgets coming up. The commit before worked (link hints, widget). Minus the corrupted thumbnails. As fancy site I tested spiegel.de . But the behaviour was on every page. (Github, Youtube) We have not talked about this, but its also on sway + wayland.
But sway + webkit2gtk (opengl off and wpe off) worked fine with hints and widgets.

Webkit2gtk: basically opengl and wpe-renderer on

cmake -B build \
    -DCMAKE_BUILD_TYPE=Release \
    -DCMAKE_INSTALL_PREFIX=/usr \
    -DLIB_INSTALL_DIR=/usr/lib \
    -DPORT=GTK \
    -DCMAKE_SKIP_RPATH=ON \
    -DENABLE_BUBBLEWRAP_SANDBOX=OFF \
    -DENABLE_SAMPLING_PROFILER=OFF \
    -DENABLE_GEOLOCATION=OFF \
    -DENABLE_GLES2=ON \
    -DENABLE_INTL=OFF \
    -DENABLE_INTROSPECTION=OFF \
    -DENABLE_MINIBROWSER=OFF \
    -DENABLE_OPENGL=ON \
    -DENABLE_SPELLCHECK=OFF \
    -DENABLE_VIDEO=${streaming:-OFF} \
    -DENABLE_WEBGL=OFF \
    -DENABLE_WEB_AUDIO=${streaming:-OFF} \
    -DUSE_LIBHYPHEN=OFF \
    -DUSE_LIBNOTIFY=OFF \
    -DUSE_LIBSECRET=OFF \
    -DUSE_OPENJPEG=${jpeg:-OFF} \
    -DUSE_WOFF2=OFF \
    -DUSE_WPE_RENDERER=ON \
    -DENABLE_WEB_CRYPTO=OFF \
    -DENABLE_MEDIASOURCE=${streaming:-OFF} \
    -Wno-dev
sdsddsd1 commented 4 years ago

Note: Commit 069fb18 is working working for me with hints and widgets. No images.
Latest commit does not work.
Did you try to reproduce with webkit2gtk with opengl and fpe-renderer? If you are not planing on more investigation we could close the issue.
Thanks for your efforts anyway. Greetings.

jun7 commented 4 years ago

It is reproduced and will take a while to fix it. Or I will set hardware-acceleration-policy=NEVER programmatically.

jun7 commented 4 years ago

The fix works with weston. Is it fixed?

sdsddsd1 commented 4 years ago

Link hints and widget (uribar) are working. Channel switcher and history still have the corrupted image. Tested on sway and hikari.

sdsddsd1 commented 4 years ago

Last commit did it. Link hints and correct images!

jun7 commented 4 years ago

BTW reordering windows (e.g. Channel switcher) not works on weston. Does it work on sway?

sdsddsd1 commented 4 years ago

When you mean keybind "z", it shows the window(picture) but does not switch to it. This would be a nice feature because currently there is nothing like "tabbed" available. I use the tabbed mode of sway for it. Edit: I does not matter if its in tabbed, tiling or floating mode.

jun7 commented 4 years ago

Hmm there is no left I can handle because I just use gtk_window_raise for reordering windows and gdk's one also not works too, so Thank you for reporting!